Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] Support buildConfiguration parameter. #394

Merged
merged 7 commits into from
May 12, 2021
Merged

[eas-cli] Support buildConfiguration parameter. #394

merged 7 commits into from
May 12, 2021

Conversation

randomhajile
Copy link
Member

@randomhajile randomhajile commented May 10, 2021 •
edited
Loading

Checklist

Why

To support arbitrary build configuration strings.

How

Replaced schemeBuildConfiguration with buildConfiguration.

Test Plan

@randomhajile randomhajile force-pushed the @mike/build-configuration branch 2 times, most recently from 44dbaae to b1b5c79 Compare May 10, 2021 23:08
@randomhajile randomhajile requested a review from wkozyra95 May 10, 2021 23:16
@randomhajile randomhajile marked this pull request as ready for review May 10, 2021 23:16
@github-actions
Copy link

github-actions bot commented May 10, 2021 •
edited
Loading

Size Change: +269 B (0%)

Total Size: 32.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 32.9 MB +269 B (0%)

compressed-size-action

@randomhajile randomhajile force-pushed the @mike/build-configuration branch from 061c24b to 2082118 Compare May 10, 2021 23:40
wkozyra95
wkozyra95 reviewed May 11, 2021
View reviewed changes
packages/eas-cli/src/build/ios/prepareJob.ts Outdated Show resolved Hide resolved
packages/eas-json/src/Config.types.ts Outdated Show resolved Hide resolved
packages/eas-json/src/__tests__/EasJsonReader-test.ts Outdated Show resolved Hide resolved
packages/eas-json/src/__tests__/EasJsonReader-test.ts Outdated Show resolved Hide resolved
packages/eas-json/src/EasJsonSchema.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@wkozyra95
Copy link
Contributor

wkozyra95 commented May 11, 2021 •
edited
Loading

Sorry if was not clear, we want to keep old field name in eas.json, just update field in a job

@randomhajile randomhajile requested a review from wkozyra95 May 11, 2021 18:24
wkozyra95
wkozyra95 approved these changes May 12, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@randomhajile randomhajile merged commit 8e3d84b into main May 12, 2021
@randomhajile randomhajile deleted the @mike/build-configuration branch May 12, 2021 14:21
@randomhajile randomhajile mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkozyra95 wkozyra95 wkozyra95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randomhajile @wkozyra95