Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] merge everything from actions/new to actions #364

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

quinlanj
Copy link
Member

Checklist

Why

I moved everything from ios/actions/new to ios/actions, and got rid of all the old REST api actions that we no longer need. Some of the REST actions were named the same thing as the Graphql actions, which is why github shows you a substantial diff instead of just a file deletion

Test Plan

  • current tests pass

@quinlanj quinlanj requested review from dsokal and wkozyra95 April 23, 2021 22:31
@github-actions
Copy link

github-actions bot commented Apr 23, 2021

Size Change: -6.22 kB (0%)

Total Size: 32.8 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 32.8 MB -6.22 kB (0%)

compressed-size-action

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that it was finally possible to do that! 👏
Remember to fix the lint warnings.

Base automatically changed from @quin/swap0 to main April 26, 2021 19:07
delete unused actions

delete old inner class

remove uneeded dist cert utils

merge dist cert utils

remove unused functions of pprofile utils

pop out new directory
@quinlanj quinlanj merged commit 1a7edbe into main Apr 26, 2021
@quinlanj quinlanj deleted the @quin/swap1 branch April 26, 2021 19:10
@quinlanj
Copy link
Member Author

yup, i fixed it in the stacked PR on top of this one, so i'll land both of them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants