implement SetupInternalProvisioningProfile #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.79 kB (0%) Total Size: 32.8 MB
|
wkozyra95
reviewed
Apr 19, 2021
packages/eas-cli/src/credentials/ios/actions/new/SetupInternalProvisioningProfile.ts
Outdated
Show resolved
Hide resolved
| return await this.setupAdhocProvisioningProfile(ctx); | ||
| } | ||
| } else { | ||
| if (adhocBuildCredentials && enterpriseBuildCredentials) { |
There was a problem hiding this comment.
it's never falsy, it will be either one element list or empty list
| 'Which credentials would you like to set up?' | ||
| ); | ||
| } else { | ||
| return await this.setupAdhocProvisioningProfile(ctx); |
b844396 to
34353ab
Compare
wkozyra95
approved these changes
Apr 22, 2021
| ctx: Context, | ||
| accountName: string, | ||
| action: ActionType | ||
| ): Action { | ||
| ): Action<void> | Action<IosAppBuildCredentialsFragment> { |
There was a problem hiding this comment.
Suggested change
| ): Action<void> | Action<IosAppBuildCredentialsFragment> { | |
| ): Action<unknown> { |
| @@ -26,10 +26,13 @@ interface Options { | |||
| skipCredentialsCheck?: boolean; | |||
| } | |||
|
|
|||
| export class SetupBuildCredentials implements Action { | |||
| export class SetupBuildCredentials implements Action<IosAppBuildCredentialsFragment> { | |||
There was a problem hiding this comment.
SetupBuildCredentials.runAsync should return sth like IosAppBuildCredentialsFragment but field shouldnt be optional
| import { SetupAdhocProvisioningProfile } from './SetupAdhocProvisioningProfile'; | ||
| import { SetupProvisioningProfile } from './SetupProvisioningProfile'; | ||
|
|
||
| export class SetupInternalProvisioningProfile { |
There was a problem hiding this comment.
Some description would be usefull here, both for what behaviour we implement, but also in what context it will be executed e.g, we assume that "enterpriseProvisioning" is not specified
1 task
ee473f3 to
9344d06
Compare
wkozyra95
approved these changes
Apr 22, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
enterpriseProvisioningproperty ineas.json.How
SetupInternalProvisioningProfile- it's run when the user didn't specify theenterpriseProvisioningproperty in eas.json.--skip-credentials-checkflag for iOS builds. The flag was necessary because we didn't have proper offline validation of the provisioning profile/distribution certificate. This PR adds the offline dist cert validation and makes it possible to get rid of the flag.Test Plan
Added unit tests.