-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] suggest using eas build:dev when using simulator/emulator dev client configuration #2929
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Subscribed to pull request
Generated by CodeMention |
Size Change: -4.39 kB (-0.01%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
- Coverage 52.68% 52.63% -0.05%
==========================================
Files 588 588
Lines 23219 23242 +23
Branches 4614 4626 +12
==========================================
Hits 12231 12231
- Misses 10954 10977 +23
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's give it a try!
it might also be useful to check for a build with the same profile with a matching fingerprint and let people know about that |
…ev client configuration
d1595a8
to
e9936a5
Compare
I added this message at the end of the build process. I believe we would need to add the check at the beginning instead, right? I believe I can merge this PR the way it is and we can figure out the best way to add the fingerprint check in a separate PR. |
✅ Thank you for adding the changelog entry! |
Why
Suggest using
eas build:dev
if one runseas build
resulting in simulator/emulator dev client build.How
Add log to suggest using
eas build:dev
Test Plan
Tests