Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] suggest using eas build:dev when using simulator/emulator dev client configuration #2929

Conversation

szdziedzic
Copy link
Contributor

@szdziedzic szdziedzic commented Mar 5, 2025

Why

Suggest using eas build:dev if one runs eas build resulting in simulator/emulator dev client build.

How

Add log to suggest using eas build:dev

Test Plan

Tests

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review March 5, 2025 11:49
Copy link

github-actions bot commented Mar 5, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Mar 5, 2025

Size Change: -4.39 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -4.39 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (34c307c) to head (a87155c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/build/index.ts 4.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
- Coverage   52.68%   52.63%   -0.05%     
==========================================
  Files         588      588              
  Lines       23219    23242      +23     
  Branches     4614     4626      +12     
==========================================
  Hits        12231    12231              
- Misses      10954    10977      +23     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a try!

@brentvatne
Copy link
Member

it might also be useful to check for a build with the same profile with a matching fingerprint and let people know about that

@szdziedzic szdziedzic force-pushed the 03-05-_eas-cli_suggest_using_eas_build_dev_when_using_simulator_emulator_dev_client_configuration branch from d1595a8 to e9936a5 Compare March 6, 2025 11:40
@szdziedzic
Copy link
Contributor Author

it might also be useful to check for a build with the same profile with a matching fingerprint and let people know about that

I added this message at the end of the build process. I believe we would need to add the check at the beginning instead, right?

I believe I can merge this PR the way it is and we can figure out the best way to add the fingerprint check in a separate PR.

Copy link

github-actions bot commented Mar 6, 2025

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 759d749 into main Mar 6, 2025
11 checks passed
@szdziedzic szdziedzic deleted the 03-05-_eas-cli_suggest_using_eas_build_dev_when_using_simulator_emulator_dev_client_configuration branch March 6, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants