Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] amend fingerprint compare url #2923

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 26, 2025

before merging

Why

Updates the fingerprint comparison URL structure to use path parameters instead of query parameters, making it consistent with the new URL format on the Expo website.

How

Modified the URL construction in the fingerprint comparison command to include the fingerprint hashes directly in the path instead of as search parameters. The new format follows the pattern:
/accounts/{account}/projects/{project}/fingerprints/compare/{firstHash}/{secondHash}

Test Plan

Ran fingerprint:compare with and without the --open flag

Example:

$ eas fingerprint compare first-hash second-hash
# Should generate URL: /accounts/user/projects/app/fingerprints/compare/first-hash/second-hash

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@quinlanj quinlanj requested a review from szdziedzic February 26, 2025 23:09
@quinlanj quinlanj marked this pull request as ready for review February 26, 2025 23:09
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 26, 2025

Size Change: +2.61 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +2.61 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.64%. Comparing base (2790fd4) to head (95fabef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2923      +/-   ##
==========================================
+ Coverage   52.64%   52.64%   +0.01%     
==========================================
  Files         588      588              
  Lines       23203    23201       -2     
  Branches     4613     4613              
==========================================
  Hits        12212    12212              
+ Misses      10957    10955       -2     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj force-pushed the 02-26-_eas-cli_amend_fingerprint_compare_url branch from c08a818 to 95fabef Compare February 27, 2025 19:39
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit c19a737 into main Feb 27, 2025
11 checks passed
@quinlanj quinlanj deleted the 02-26-_eas-cli_amend_fingerprint_compare_url branch February 27, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants