Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] lowercase urls, add more pretty prints #2909

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 14, 2025

Why

The current fingerprint comparison URLs and content identifiers need improvements:

  1. URLs should be case-insensitive to match Expo's website behavior
  2. Content identifiers need clearer labels and additional React Native specific entries

How

  • Modified URL generation to lowercase account and project names for consistency
  • Updated and added new content identifier labels:
    • Renamed "Expo config" to "Expo app config" for clarity
    • Added entries for React Native package.json
    • Added entries for React Native Community autolinking configs

Test Plan

Ran eas fingerprint:compare to ensure:

  1. fingerprint comparison URLs work with mixed case account/project names
  2. Verify content identifiers display correctly

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 14, 2025

Size Change: -229 B (0%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB -229 B (0%)

compressed-size-action

@quinlanj quinlanj marked this pull request as ready for review February 14, 2025 20:38
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.63%. Comparing base (30c5e9f) to head (a15ecd6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2909   +/-   ##
=======================================
  Coverage   52.63%   52.63%           
=======================================
  Files         588      588           
  Lines       23200    23200           
  Branches     4859     4859           
=======================================
  Hits        12210    12210           
  Misses      10021    10021           
  Partials      969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj requested a review from brentvatne February 21, 2025 20:17
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 4b8a9d1 into main Feb 24, 2025
7 checks passed
@quinlanj quinlanj deleted the 02-14-_eas-cli_lowercase_urls_add_more_pretty_prints branch February 24, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants