Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-14643][eas-cli] make automatic env resolution message shorter #2806

Merged

Conversation

szdziedzic
Copy link
Member

Why

https://linear.app/expo/issue/ENG-14643/shorten-the-message-about-env-selection-for-a-build

How

Shorten the message about env selection for a build

Test Plan

Test manually

Copy link

linear bot commented Jan 8, 2025

Copy link

github-actions bot commented Jan 8, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Jan 8, 2025

Size Change: +1.55 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.55 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (608cdff) to head (11f1a70).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...as-cli/src/build/evaluateConfigWithEnvVarsAsync.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
+ Coverage   52.47%   52.48%   +0.01%     
==========================================
  Files         583      583              
  Lines       22606    22603       -3     
  Branches     4460     4461       +1     
==========================================
  Hits        11860    11860              
+ Misses      10711    10708       -3     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the @szdziedzic/make-automatic-env-resolution-message-shorter branch from ac67841 to 11f1a70 Compare January 10, 2025 09:55
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 86c8ac0 into main Jan 10, 2025
10 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/make-automatic-env-resolution-message-shorter branch January 10, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants