Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add message about concurrency add-on #2611

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

brentvatne
Copy link
Member

Why

Let people know that they can add more concurrencies easily

How

Make the message more clear

Test Plan

Copy link

github-actions bot commented Oct 7, 2024

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela

Copy link

github-actions bot commented Oct 7, 2024

Size Change: -2.24 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.24 kB (0%)

compressed-size-action

@brentvatne
Copy link
Member Author

/changelog-entry chore Let folks know about the new concurrency add-on

Copy link
Contributor

@keith-kurak keith-kurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an idea for a verbiage tweak, but looks good to me!

brentvatne and others added 2 commits October 11, 2024 10:10
Co-authored-by: Keith Kurak <keith.kurak@gmail.com>
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (a346af2) to head (48a4700).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/build.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2611    +/-   ##
========================================
  Coverage   53.09%   53.09%            
========================================
  Files         563      563            
  Lines       21399    21399            
  Branches     4390     4162   -228     
========================================
  Hits        11360    11360            
- Misses       9201    10010   +809     
+ Partials      838       29   -809     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentvatne brentvatne merged commit 496e689 into main Oct 11, 2024
9 checks passed
@brentvatne brentvatne deleted the @brent/build-concurrency-message branch October 11, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants