Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): update eas worker:alias with same polishes from eas worker #2558

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 12, 2024

Why

See #2555, this applies the same polishes in terms of help and normal command output.

How

See #2555

Test Plan

easd deploy:alias --help image
easd deploy:alias --id xxx --alias pr-test image

Copy link

github-actions bot commented Sep 12, 2024

Size Change: -931 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -931 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.24%. Comparing base (d15cd90) to head (d43cba9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/alias.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
- Coverage   52.24%   52.24%   -0.00%     
==========================================
  Files         557      557              
  Lines       21004    21006       +2     
  Branches     4291     4291              
==========================================
+ Hits        10972    10973       +1     
- Misses       9167     9168       +1     
  Partials      865      865              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric force-pushed the @bycedric/eas-cli/worker-asign-update-command branch from c1f4384 to 3883be9 Compare September 12, 2024 16:32
@byCedric byCedric requested a review from kitten September 12, 2024 19:19
Base automatically changed from @bycedric/eas-cli/worker-prod-production-flag-alias to main September 13, 2024 11:53
@byCedric byCedric force-pushed the @bycedric/eas-cli/worker-asign-update-command branch from 3883be9 to d43cba9 Compare September 13, 2024 11:57
Copy link

✅ Thank you for adding the changelog entry!

@byCedric byCedric merged commit 2fb079d into main Sep 13, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/worker-asign-update-command branch September 13, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants