Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Upload fingeprint source as part of eas update command #2533

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Sep 3, 2024

Why

Fingerprints are generated at build time and update time, and associated with runtime versions in EAS. Therefore, the fingerprint needs to be supplied as part of publishing an update.

This PR adds support for this.

Closes ENG-12855.

How

Refactor code to do the upload for both builds and updates.

Test Plan

In a project that uses the fingerprint rtv policy:

  1. neas update
  2. open update on website
  3. Query in graphiql:
query {
  updates {
    byId(updateId: "...") {
      runtime {
        fingerprintDebugInfoUrl
      }
    }
  }
}

See that the runtime has the fingerprint debug info and going to the URL appropriately downloads it.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Sep 3, 2024

Size Change: +136 B (0%)

Total Size: 51.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.9 MB +136 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 55.44554% with 45 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (6245fb4) to head (368a2a9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eas-cli/src/project/maybeUploadFingerprintAsync.ts 38.47% 14 Missing and 2 partials ⚠️
.../eas-cli/src/project/resolveRuntimeVersionAsync.ts 7.15% 13 Missing ⚠️
packages/eas-cli/src/commands/update/index.ts 76.93% 2 Missing and 4 partials ⚠️
packages/eas-cli/src/build/graphql.ts 16.67% 4 Missing and 1 partial ⚠️
packages/eas-cli/src/project/publish.ts 85.72% 3 Missing ⚠️
packages/eas-cli/src/build/build.ts 33.34% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
+ Coverage   52.75%   52.86%   +0.11%     
==========================================
  Files         548      549       +1     
  Lines       20476    20529      +53     
  Branches     4185     4194       +9     
==========================================
+ Hits        10801    10850      +49     
- Misses       8836     8838       +2     
- Partials      839      841       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman force-pushed the @wschurman/09-03-_eas-cli_upload_fingeprint_source_as_part_of_eas_update_command branch from 5c0f07a to 368a2a9 Compare September 4, 2024 18:26
Copy link

github-actions bot commented Sep 4, 2024

✅ Thank you for adding the changelog entry!

@wschurman wschurman marked this pull request as ready for review September 4, 2024 18:27
Copy link

linear bot commented Sep 4, 2024

Copy link
Contributor

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👍

@wschurman wschurman merged commit b32ff2e into main Sep 5, 2024
10 checks passed
@wschurman wschurman deleted the @wschurman/09-03-_eas-cli_upload_fingeprint_source_as_part_of_eas_update_command branch September 5, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants