-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Upload fingeprint source as part of eas update command #2533
[eas-cli] Upload fingeprint source as part of eas update command #2533
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @wschurman and the rest of your teammates on Graphite |
Size Change: +136 B (0%) Total Size: 51.9 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
+ Coverage 52.75% 52.86% +0.11%
==========================================
Files 548 549 +1
Lines 20476 20529 +53
Branches 4185 4194 +9
==========================================
+ Hits 10801 10850 +49
- Misses 8836 8838 +2
- Partials 839 841 +2 ☔ View full report in Codecov by Sentry. |
5c0f07a
to
368a2a9
Compare
✅ Thank you for adding the changelog entry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM 👍
Why
Fingerprints are generated at build time and update time, and associated with runtime versions in EAS. Therefore, the fingerprint needs to be supplied as part of publishing an update.
This PR adds support for this.
Closes ENG-12855.
How
Refactor code to do the upload for both builds and updates.
Test Plan
In a project that uses the fingerprint rtv policy:
neas update
See that the runtime has the fingerprint debug info and going to the URL appropriately downloads it.