-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Add explicit workflow arg to expo-update CLI calls #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
requested review from
EvanBacon,
byCedric,
szdziedzic,
khamilowicz and
sjchmiela
as code owners
April 24, 2024 04:03
wschurman
requested review from
quinlanj and
douglowder
and removed request for
sjchmiela,
byCedric,
khamilowicz and
EvanBacon
April 24, 2024 04:03
Size Change: -989 B (0%) Total Size: 51.4 MB
|
szdziedzic
approved these changes
Apr 24, 2024
szdziedzic
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix tests 🙏
/changelog-entry bug-fix Add explicit workflow arg to expo-update CLI calls |
✅ Thank you for adding the changelog entry! |
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
eas-cli part of expo/expo#28403 and expo/eas-build#384.
Closes ENG-12107.
How
Pass workflow through so that the workflow inference within expo-updates isn't necessary.
Test Plan
Follow test plan of expo/eas-build#384 for project setup, then:
neas update