Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add explicit workflow arg to expo-update CLI calls #2340

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

wschurman
Copy link
Member

Why

eas-cli part of expo/expo#28403 and expo/eas-build#384.

Closes ENG-12107.

How

Pass workflow through so that the workflow inference within expo-updates isn't necessary.

Test Plan

Follow test plan of expo/eas-build#384 for project setup, then:

neas update

Copy link

linear bot commented Apr 24, 2024

@wschurman wschurman requested review from quinlanj and douglowder and removed request for sjchmiela, byCedric, khamilowicz and EvanBacon April 24, 2024 04:03
Copy link

github-actions bot commented Apr 24, 2024

Size Change: -989 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -989 B (0%)

compressed-size-action

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests 🙏

@wschurman
Copy link
Member Author

/changelog-entry bug-fix Add explicit workflow arg to expo-update CLI calls

Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 383caa0 into main Apr 24, 2024
6 checks passed
@wschurman wschurman deleted the @wschurman/add-explicit-workflow-arguments branch April 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants