-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/2][eas-cli] paginated progress bar #2326
Conversation
Size Change: +104 B (0%) Total Size: 51.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2326 +/- ##
==========================================
+ Coverage 53.68% 53.73% +0.06%
==========================================
Files 525 525
Lines 19190 19226 +36
Branches 4054 4061 +7
==========================================
+ Hits 10301 10330 +29
- Misses 8162 8171 +9
+ Partials 727 725 -2 ☔ View full report in Codecov by Sentry. |
/changelog-entry chore add progress bar for fetching paginated datasets |
✅ Thank you for adding the changelog entry! |
background
There are a couple flows in
eas-cli
where we fetch the user's entire dataset (ie) dist certs, push keys, etc. We don't expect the user to have many, but sometimes there are outlier users who end up having way more items than expected. I'm moving these fetches to use our paginated endpoints. We currently attempt to fetch the entire dataset in one request, and for the outlier users with many items, it causes the request to fail/timeout.Why
This PR makes a generic pagination fetcher to get an entire dataset.
medium-150-items-dataset.mov
large-600-items.mov
Test Plan