-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Improve reliability of update asset presigned upload requests #1278
Conversation
28d7b4e
to
eda7d1d
Compare
Size Change: +19.1 kB (0%) Total Size: 40.9 MB
|
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 51.32% 51.26% -0.06%
==========================================
Files 400 400
Lines 14092 14111 +19
Branches 2939 2942 +3
==========================================
+ Hits 7231 7232 +1
- Misses 6329 6345 +16
- Partials 532 534 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/changelog-entry new-feature Improve reliability of update asset presigned upload requests |
1ff5f69
to
fe40ba3
Compare
|
||
>>>>>>> 1ff5f69a (update CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh lol
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]
and CHANGELOG.md will be updated automatically.Why
Google cloud storage says to retry with exponential backoff when the uploads throw an error: https://cloud.google.com/storage/docs/request-rate
I was seeing
ECONNRESET
errors locally when uploading huge numbers of assets, and this seemed to fix it.How
Add
promise-retry
with 3 retries with exponential backoff.Test Plan
With app with 3k assets, run:
(pointed at my local EAS server with the 700 limit disabled temporarily)