Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zshot Spacy plugin #11557

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Add Zshot Spacy plugin #11557

merged 3 commits into from
Sep 29, 2022

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Sep 29, 2022

Add Zshot (Zero and Few shot named entity & relationships recognition) Spacy plugin

Description

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Add Zshot (Zero and Few shot named entity & relationships recognition) Spacy plugin
Copy link
Contributor

@adrianeboyd adrianeboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a few formatting edits...

GabrielePicco and others added 2 commits September 29, 2022 13:48
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
@GabrielePicco
Copy link
Contributor Author

Thanks @adrianeboyd , just committed your suggestions.

@svlandeg svlandeg added the docs Documentation and website label Sep 29, 2022
@adrianeboyd
Copy link
Contributor

Thanks for the quick response!

As a note, we'd recommend specifying the dependency as spacy>=3.4.1,<4.0.0 so that your package continues to run as intended even if there is a breaking change in spacy v4.

@GabrielePicco
Copy link
Contributor Author

Thanks @adrianeboyd , I will include this change for our next release. Is it something that need to be changed before merging this PR?

@adrianeboyd
Copy link
Contributor

No, it's just intended as a suggestion.

@GabrielePicco
Copy link
Contributor Author

Awesome thanks. Looking forward to see the PR merged. Let me know if anything else is needed from our side.

@adrianeboyd adrianeboyd merged commit ff9002b into explosion:master Sep 29, 2022
adrianeboyd added a commit that referenced this pull request Sep 29, 2022
* Add Zshot Spacy plugin

Add Zshot (Zero and Few shot named entity & relationships recognition) Spacy plugin

* Update website/meta/universe.json

Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>

* Update website/meta/universe.json

Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>

Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
@GabrielePicco GabrielePicco deleted the patch-1 branch September 29, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation and website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants