Prevent tok2vec to broadcast to listeners when predicting #11385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing the same problem as laid out in explosion/spacy-transformers#342, i.e. the fact that
tok2vec.predict
broadcasts the outputs to the listeners, breaks the usual contract in which the training mechanism should rely on that broadcasting, but in prediction we should usedoc.tensor
.Because we still want to be able to have a frozen (but annotating!) embedding layer, have a fallback in the listener's
forward
function that will access thedoc.tensor
even when training, if there is otherwise no valid data available.Types of change
bug fix
Checklist