-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cupy extras #11279
Update cupy extras #11279
Conversation
* Extend to v11 * Add `cupy-cuda11x` and `cupy-wheel` * Update quickstart to use `cupy-wheel` for CUDA 10.2+
I'm not sure about the extra name If you use |
I don't really like
We can keep the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment.
Looking at it again, I'm not sure |
For the record, this is the thread for status of It's not clearly stated, but it looks like it's supposed to work for CUDA 10.2 and not just 11+ - see the "supported packages" in the PR here. It looks like there are some environments (like Docker) where there may be issues with it still, though it seems to be working fine for normal use. |
Hi, CuPy maintainer here. I'd suggest naming the extras_require as |
Thanks for the info! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
cupy-cuda11x
andcupy-wheel
cupy-wheel
for CUDA 10.2+Types of change
Checklist