Added short circuit to matching

Signed-off-by: expani <anijainc@amazon.com>
expani · Jan 28, 2025 · 204a107 · 204a107
1 parent b19c4e5
commit 204a107
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/server/src/test/java/org/opensearch/search/aggregations/startree/ArrayBasedCollector.java b/server/src/test/java/org/opensearch/search/aggregations/startree/ArrayBasedCollector.java
@@ -29,11 +29,10 @@ public void collectStarTreeNode(StarTreeNode node) {
     }
 
     public boolean matchAllCollectedValues(long... values) throws IOException {
-        boolean matches = true;
         for (long value : values) {
-            matches &= nodeDimensionValues.contains(value);
+            if (!nodeDimensionValues.contains(value)) return false;
         }
-        return matches;
+        return true;
     }
 
     public int collectedNodeCount() {