Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browse by ISRC and artistCredits #86

Merged
merged 2 commits into from
Sep 16, 2018
Merged

Fix browse by ISRC and artistCredits #86

merged 2 commits into from
Sep 16, 2018

Conversation

exogen
Copy link
Owner

@exogen exogen commented Sep 16, 2018 •
edited
Loading

  • Fix browse by ISRC to mark the returned recordings entities as recordings.
  • Fix artistCredits field to use the artist-credits inc parameter while still reading from the artist-credit property.
  • Log the actual full URL of outgoing requests by reading req.uri.href.
  • Update test suite.

Fixes #85.

@exogen exogen mentioned this pull request Sep 16, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 91.338% when pulling 57f2638 on fix/browse-by-isrc-artist-credits into fc6f133 on master.

@exogen exogen merged commit 50d3268 into master Sep 16, 2018
@exogen exogen deleted the fix/browse-by-isrc-artist-credits branch September 16, 2018 23:21
@exogen
Copy link
Owner Author

exogen commented Sep 16, 2018

Published in v8.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exogen @coveralls