Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two-bucket: fix incorrect test case #795

Merged
merged 2 commits into from
Oct 12, 2017
Merged

two-bucket: fix incorrect test case #795

merged 2 commits into from
Oct 12, 2017

Conversation

cmccandless
Copy link
Contributor

Resolves #794

@ilya-khadykin
Copy link
Contributor

@cmccandless, thanks for updating this one. Example implementation should also pass the new test

Could you also check to what version of canonical-data.json is based on and state it in the comment inside the file

ilya-khadykin
ilya-khadykin suggested changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example implementation should also pass the new test

@ilya-khadykin ilya-khadykin merged commit cd10851 into exercism:master Oct 12, 2017
@ilya-khadykin
Copy link
Contributor

Merged, thanks for fixing 🛠

@cmccandless cmccandless deleted the two-bucket-fix-test-case branch October 17, 2017 17:05
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 21, 2021
@ErikSchierboom @iHiD
@kotp @SaschaMann
Add docs/reference split (exercism#795)
63808a4 
* [Docs] Move implementing-a-concept-exercise.md to reference folder
* [Docs] Move reference documents to docs folder
* [Docs] Update to student-facing docs
* [Docs] Add new issue template

Co-Authored-By: Jeremy Walker <jez.walker@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 22, 2021
@ErikSchierboom @iHiD
@kotp @SaschaMann
Add docs/reference split (exercism#795)
f552f16 
* [Docs] Move implementing-a-concept-exercise.md to reference folder
* [Docs] Move reference documents to docs folder
* [Docs] Update to student-facing docs
* [Docs] Add new issue template

Co-Authored-By: Jeremy Walker <jez.walker@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 26, 2021
@ErikSchierboom @iHiD
@kotp @SaschaMann
Add docs/reference split (exercism#795)
cdd524c 
* [Docs] Move implementing-a-concept-exercise.md to reference folder
* [Docs] Move reference documents to docs folder
* [Docs] Update to student-facing docs
* [Docs] Add new issue template

Co-Authored-By: Jeremy Walker <jez.walker@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 27, 2021
@ErikSchierboom @iHiD
@kotp @SaschaMann
Add docs/reference split (exercism#795)
54e1662 
* [Docs] Move implementing-a-concept-exercise.md to reference folder
* [Docs] Move reference documents to docs folder
* [Docs] Update to student-facing docs
* [Docs] Add new issue template

Co-Authored-By: Jeremy Walker <jez.walker@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-khadykin ilya-khadykin ilya-khadykin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmccandless @ilya-khadykin