protein-translation: update tests to v1.1.0 #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the issue I've referenced should be #440. |
|
@mrcfps you can modify commit messages git commit --amend (or git rebase -i master)
git push -f |
51969b5 to
6071a7c
Compare
cmccandless
suggested changes
Feb 20, 2018
|
|
||
| def test_stops_translation_if_stop_codon_in_middle_of_six_codon_sequence( | ||
| self): | ||
| strand = 'UGGUGUUAUUAAUGGUUU' | ||
| expected = ['Tryptophan', 'Cysteine', 'Tyrosine'] | ||
| self.assertEqual(expected, proteins(strand)) | ||
| self.assertEqual(proteins(strand), expected) | ||
|
|
||
| # Utility functions |
There was a problem hiding this comment.
Since this exercise no longer has tests that expected exceptions, I think it's safe to remove the Utility functions block
cmccandless
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1245.
Since canonical data was only updated for new input policy, which has nothing to do with test file in Python, so update of version number suffices.