Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create maintainer-specific docs #1095

Closed
1 task
ilya-khadykin opened this issue Nov 7, 2017 · 6 comments
Closed
1 task

Create maintainer-specific docs #1095

ilya-khadykin opened this issue Nov 7, 2017 · 6 comments

Comments

@ilya-khadykin
Copy link
Contributor

ilya-khadykin commented Nov 7, 2017

As mentioned in #1086 I think we should create some sort of maintainer-specific docs and document thing related to the best practices we use. It will help us stay on the same page etc

What do you think?

TODO:

@cmccandless
Copy link
Contributor

Some of the information I would imagine the proposed docs would contain (Conventions, Code Style) is already in the README. I don't see why we couldn't put label documentation there as well?

@ilya-khadykin
Copy link
Contributor Author

I thought that README is targeting contributors more than maintainers. For that reason I've created this issue

@N-Parsons
Copy link
Contributor

@m-a-ge, I'm not sure what documentation we'd need that is specific to maintainers?

However, I think it might be worth putting together a CONTRIBUTING.md (or equivalent) that would give more detail than the README currently does about how to contribute, what conventions we follow, etc. This would be useful both for new people to find and read, and for us to be able to point to when something isn't quite right with a PR. We could probably achieve a lot of the kinds of things you are thinking about with such a document?

@ilya-khadykin
Copy link
Contributor Author

@N-Parsons yes, that's a good idea

@N-Parsons
Copy link
Contributor

Coming from #1080, part of this documentation could be a list of exception types and when to use them (something like the Choosing Exceptions to Raise Pandas has).

@cmccandless
Copy link
Contributor

For now, the README for this track is adequate as a contributing guide. If someone submits a PR for a more comprehensive CONTRIBUTING.md, it would be welcome, but this is not an urgent need at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants