Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inconsistency Between Hints and Test Cases in Robot Simulator #1190

Merged

Conversation

mrsekut
Copy link
Contributor

@mrsekut mrsekut commented Dec 21, 2023

I've noticed a discrepancy between the hints provided and the actual required functions in the Robot Simulator exercise. The hints suggest that the following functions are necessary:

  • bearing
  • coordinates
  • mkRobot
  • simulate
  • turnLeft
  • turnRight

However, upon reviewing the test cases, it seems that the actual required functions are:

  • bearing
  • coordinates
  • mkRobot
  • move

This mismatch might cause confusion for users trying to solve the problem. Therefore, I've made the necessary adjustments to align the hints with the test cases.

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Dec 21, 2023
@MatthijsBlom
Copy link
Contributor

@ErikSchierboom Can you please merge this one?

@ErikSchierboom ErikSchierboom reopened this Jan 2, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ErikSchierboom
Copy link
Member

@MatthijsBlom Is the CI error safe to ignore?

@MatthijsBlom
Copy link
Contributor

I think so.

@ErikSchierboom ErikSchierboom merged commit 292d268 into exercism:main Jan 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants