Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#256: Fixed type hints #260

Merged
merged 12 commits into from
Jan 27, 2025
Merged

#256: Fixed type hints #260

merged 12 commits into from
Jan 27, 2025

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Jan 24, 2025 •
edited by ckunki
Loading

fixes #256

  1. Add return type to all methods which are in exasol.slc.*
  2. Fixed type hint of = luigi.ListParameter(), which actually is a Tuple, not a List
  3. Added assertions for returned objects from futures, in order to validate correctness of Type Hints

@tomuben tomuben merged commit 157b91c into main Jan 27, 2025
48 checks passed
@tomuben tomuben deleted the refactoring/256_fix_type_hints branch January 27, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

@ckunki ckunki ckunki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type hints
3 participants
@tomuben @tkilias @ckunki