Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestContainer doesn't get rebuild with force_rebuild set #291

Closed
tkilias opened this issue Mar 23, 2023 · 0 comments · Fixed by #315
Closed

TestContainer doesn't get rebuild with force_rebuild set #291

tkilias opened this issue Mar 23, 2023 · 0 comments · Fixed by #315
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@tkilias
Copy link
Contributor

tkilias commented Mar 23, 2023

Background

  • When we set force_rebuild to true, we would expect that build steps such as AnalyzeTestContainer would get rebuilt
  • However, the AnalyzeTestContainer implements the is_rebuild_requested method with a simple false, it needs to check the build_config().force_rebuild config

Acceptance Criteria

  • Check build_config().force_rebuild config in is_rebuild_requested
@tkilias tkilias added the bug Unwanted / harmful behavior label Mar 23, 2023
@tkilias tkilias self-assigned this May 10, 2023
tkilias added a commit that referenced this issue May 11, 2023
…ue (#315)

* Fixed that test container gets rebuild when force_rebuild is true
* Sped up the test_api_build_test_container by using a mock test_container_content with an empty Dockerfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
1 participant