Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply mode #188

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Apply mode #188

merged 7 commits into from
Feb 13, 2024

Conversation

greole
Copy link
Collaborator

@greole greole commented Feb 13, 2024

This PR prohibits calling run -o apply and introduces a new mode obr apply. This makes handling CLI arguments for apply much easier.

Copy link
Collaborator

@lupeterm lupeterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, LGTM, just two nitpicks.
I guess we can introduce the --tag option later on

src/obr/cli.py Outdated
@click.option(
"--folder",
default=".",
help="Where to create the worspace and view. Default: '.' ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="Where to create the worspace and view. Default: '.' ",
help="Where to create the workspace and view folders. Default: '.' ",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there are two help's right?

@greole greole merged commit 1071899 into dev Feb 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants