-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply mode #188
Apply mode #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM, just two nitpicks.
I guess we can introduce the --tag
option later on
src/obr/cli.py
Outdated
@click.option( | ||
"--folder", | ||
default=".", | ||
help="Where to create the worspace and view. Default: '.' ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help="Where to create the worspace and view. Default: '.' ", | |
help="Where to create the workspace and view folders. Default: '.' ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there are two help
's right?
Co-authored-by: Lukas Petermann <60653355+lupeterm@users.noreply.github.com>
This PR prohibits calling
run -o apply
and introduces a new modeobr apply
. This makes handling CLI arguments for apply much easier.