Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

fix: commented out importer test (fixes #659) #691

Merged
merged 4 commits into from
Oct 22, 2021

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Oct 22, 2021

Closes: #659

Description

updated the importer test as a test suite
plus added the block export file
from https://github.com/cosmos/ethermint/blob/development/importer/blockchain


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! can we also re-add the CI check?

@tomtau tomtau requested a review from fedekunze October 22, 2021 10:01
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending CI fix

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #691 (30b680d) into main (ac75a9a) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   57.38%   57.20%   -0.19%     
==========================================
  Files          64       63       -1     
  Lines        5583     5545      -38     
==========================================
- Hits         3204     3172      -32     
+ Misses       2215     2209       -6     
  Partials      164      164              
Impacted Files Coverage Δ
tests/importer/chain_ctx.go

@fedekunze fedekunze merged commit 1474c70 into evmos:main Oct 22, 2021
@fedekunze
Copy link
Contributor

fedekunze commented Oct 22, 2021

@tomtau it seems that the importer test was also run on the rpc-tests and that's why they are failing, can you fix it?

https://github.com/tharsis/ethermint/runs/3974441400?check_suite_focus=true

@tomtau
Copy link
Contributor Author

tomtau commented Oct 25, 2021

#700

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commented out importer test
2 participants