This repository was archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 582
fix: commented out importer test (fixes #659) #691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the importer test as a test suite plus added the block export file from https://github.com/cosmos/ethermint/blob/development/importer/blockchain
fedekunze
reviewed
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! can we also re-add the CI check?
fedekunze
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, pending CI fix
Codecov Report
@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 57.38% 57.20% -0.19%
==========================================
Files 64 63 -1
Lines 5583 5545 -38
==========================================
- Hits 3204 3172 -32
+ Misses 2215 2209 -6
Partials 164 164
|
@tomtau it seems that the importer test was also run on the rpc-tests and that's why they are failing, can you fix it? https://github.com/tharsis/ethermint/runs/3974441400?check_suite_focus=true |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #659
Description
updated the importer test as a test suite
plus added the block export file
from https://github.com/cosmos/ethermint/blob/development/importer/blockchain
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)