Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

feat: add goreleaser workflow #295

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 15, 2021

Closes #296

Description

Add a goreleaser github action workflow.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang changed the title add goreleaser workflow feat: add goreleaser workflow Jul 15, 2021
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang
Copy link
Contributor Author

yihuang commented Jul 15, 2021

this looks ok, but should we use the goreleaser action instead?

https://github.com/goreleaser/goreleaser-action
https://goreleaser.com/ci/actions/
https://github.com/cosmos/cosmos-sdk/blob/master/.github/workflows/tag.yml

that looks good too, when did the RELEASE_CHANGELOG.md get generated?

@fedekunze
Copy link
Collaborator

when did the RELEASE_CHANGELOG.md get generated?

not sure, I'd need to dig into the release process

@fedekunze
Copy link
Collaborator

let's use the GitHub action as it's easier to maintain

@yihuang yihuang force-pushed the release-workflow branch 2 times, most recently from 75032a1 to 068736e Compare July 15, 2021 09:49
@yihuang
Copy link
Contributor Author

yihuang commented Jul 15, 2021

let's use the GitHub action as it's easier to maintain

done

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I will wait for @khoslaventures 's review too

Closes #305
patch panicwrap to fix build issue

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@yihuang yihuang force-pushed the release-workflow branch from 068736e to 6d158d1 Compare July 16, 2021 03:48
@fedekunze fedekunze enabled auto-merge (squash) July 16, 2021 09:24
@fedekunze fedekunze merged commit c8ddb50 into evmos:main Jul 16, 2021
@yihuang yihuang deleted the release-workflow branch July 16, 2021 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no automatic release workflow
2 participants