This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 573
fix(rpc): add revert reason for eth_estimateGas #1722
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
- Coverage 67.94% 67.86% -0.08%
==========================================
Files 112 112
Lines 10209 10223 +14
==========================================
+ Hits 6936 6938 +2
- Misses 2865 2875 +10
- Partials 408 410 +2
|
mmsqe
requested review from
austinchandra and
GAtom22
and removed request for
a team
March 22, 2023 15:44
11 tasks
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
11 tasks
mmsqe
added a commit
to crypto-org-chain/ethermint
that referenced
this pull request
Jun 14, 2023
…rt: evmos#1722) (#270) * fix(rpc): align block number input behaviour for eth_getProof (backport: evmos#1772) (#233) * add estimate_gas test * add ret and vm_error for revert reason * compare with eth * test revertWithoutMsg * align revertWithoutMsg response for eth_estimateGas * align revertWithoutMsg response for eth_call * add change doc * separate contract to avoid gas change * update mod * fix resolve * fix doc
9 tasks
This was referenced Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To align response for reverted methods as Ethereum:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)