-
Notifications
You must be signed in to change notification settings - Fork 570
tests(websocket): websocket integration tests #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adisaran64 can you add some tests for some the rpc calls, e.g. getBlockNumber
(https://ethereum.org/en/developers/tutorials/using-websockets/) ? Or is the batch request blocking you to do this?
It would helpful to add one example of what you can query with websockets here: https://docs.evmos.org/developers/clients.html#ethereum-websocket
@adisaran64 what's the status of this PR? |
…com/evmos/ethermint into adisaran64/nix-websocket-test-suite
@danburck modified the |
LGTM, tested it locally and it's working fine. The most useful part is the fixture with the normal rpc and the websocket ( |
Closes: #1241
Description
added skeleton for websocket tests, cannot implement with current version of web3.py
along with #1342 , closes #1241
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)