Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Problem: tx log attribute value is not parsable by some clients #614

Closed
yihuang opened this issue Oct 3, 2021 · 1 comment · Fixed by #615
Closed

Problem: tx log attribute value is not parsable by some clients #614

yihuang opened this issue Oct 3, 2021 · 1 comment · Fixed by #615

Comments

@yihuang
Copy link
Contributor

yihuang commented Oct 3, 2021 •
edited
Loading

System info: ethermint main

Steps to reproduce:

  1. rust client expect the attribute value to be base64 encoded utf-8 string, while we encoded the tx log as bytes.

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Additional info:

informalsystems/tendermint-rs#1003

One solution is to encode the log in JSON in ethermint side.
@yihuang yihuang mentioned this issue Oct 3, 2021
Merged
11 tasks
yihuang added a commit to yihuang/ethermint that referenced this issue Oct 3, 2021
@yihuang
Problem: tx log attribtue value not parsable by some client

Verified

This commit was signed with the committer’s verified signature. The key has expired.
yihuang yihuang
GPG key ID: 58776091521E8B17
Expired
Verified
Learn about vigilant mode
c53ebc8 
Closes: evmos#614

Solution:
- encode the value to json string rather than bytes

Apply suggestions from code review
@thomas-nguy
Copy link
Contributor

linked to this issue informalsystems/tendermint-rs#1003

yihuang added a commit to crypto-org-chain/ethermint that referenced this issue Oct 4, 2021
@yihuang
Problem: tx log attribtue value not parsable by some client

Verified

This commit was signed with the committer’s verified signature. The key has expired.
yihuang yihuang
GPG key ID: 58776091521E8B17
Expired
Verified
Learn about vigilant mode
7b5449f 
Closes: evmos#614

Solution:
- encode the value to json string rather than bytes

Apply suggestions from code review
fedekunze added a commit that referenced this issue Oct 5, 2021
@yihuang @fedekunze
evm, rpc: fix tx log attribute value is not parsable by some client (#…

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
cda968b 
…615)

* Problem: tx log attribute value not parsable by some client

Closes: #614

Solution:
- encode the value to json string rather than bytes

Apply suggestions from code review

* rm cdc and changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
@thomas-nguy thomas-nguy mentioned this issue Oct 6, 2021
Closed
fedekunze added a commit that referenced this issue Oct 7, 2021
@yihuang @fedekunze
evm, rpc: fix tx log attribute value is not parsable by some client (#…

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 655F93A970080A30
Learn about vigilant mode
386943f 
…615)

* Problem: tx log attribute value not parsable by some client

Closes: #614

Solution:
- encode the value to json string rather than bytes

Apply suggestions from code review

* rm cdc and changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
fedekunze added a commit that referenced this issue Oct 7, 2021
@fedekunze @dependabot
@danburck @yihuang @davcrypto
release: v0.7.0 cherry picks (#645)

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
de83c87 
* docs: v0.6.0 changelog (#605) (#606)

* docs: v0.6.0 changelog

* update codeowners

* build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.0 to 0.44.1 (#610)

* build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.0 to 0.44.1

Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.44.0 to 0.44.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.44.1/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.44.0...v0.44.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* changelog

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* cmd: use config on genaccounts (#483)

* cmd: use config on genaccounts

* update

* c++

* rpc: fix panic (#611)

* rpc: fix panic

* fix

* c++

* rpc: restructure JSON-RPC directory and rename server config (#612)

* Restructure ethermint/rpc repo structure and change import statements

* Add #400 to changelog

* fix filepath in util and json_rpc

* Move #400  to unreleased section

* evm: refactor `traceTx` (#613)

* DNM: debug traceTx

* c++

* deps: bump IBC-go (#621)

* deps: bump IBC-go

* changelog

* evm, rpc:  fix tx log attribute value is not parsable by some client (#615)

* Problem: tx log attribute value not parsable by some client

Closes: #614

Solution:
- encode the value to json string rather than bytes

Apply suggestions from code review

* rm cdc and changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* evm: fix iterator on deeply nested cache contexts (#617)

* Problem: iterator on deeply nested cache contexts is extremely slow

Closes: #616

Solution:
- flatten cache contexts before doing `GetTxLogsTransient`

* Update x/evm/keeper/context_stack.go

* changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* evm: add benchmark for deep context stack (#627)

* Problem: deep context stack efficienty is not benchmarked

Closes: #626

Solution:
- add a benchmark to demonstrate an extremely inefficiency in deep
  context stack

* Update x/evm/keeper/benchmark_test.go

* prefix storage is irrelevant

* add comment to state_transition.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* rpc: support personal apis with different keyring backends (#591)

* UPDATE Unlock keyring on start

* ADD comment

* ADD validation

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* conflicts

* changelog

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: davcrypto <88310031+davcrypto@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: tx log attribtue value not parsable by some client yihuang/ethermint
2 participants
@yihuang @thomas-nguy