Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] plugin AircrackOnly - it seems to delete all the new handshakes #542

Closed
zenzen666 opened this issue Nov 6, 2019 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@zenzen666
Copy link
Contributor

Describe the bug
I've ran the plugin for one week with v1.1.1 on a pi0 and I had the 99% of all new handshakes deleted.
I haven't checked by hand if all the new handshakes was really unvalid but it seems unlikely to me.

Is it a good idea to rely on aicrack to check if a pcap is valid??

Environment (please complete the following information):

  • Pwnagotchi version 1.1.1
  • OS version
  • Type of hardware pi0
@zenzen666 zenzen666 added the bug Something isn't working label Nov 6, 2019
@FrixosTh
Copy link
Contributor

FrixosTh commented Nov 6, 2019

I believe this issue has already been resolved in v1.2.1 (v1.2.1 has a new issue which prevents AircrackOnly plugin to load - This should be resolved in the next release)
Please see raised bug #506 and #536 for reference

@evilsocket
Copy link
Owner

ok i'm done with this plugin, i'm removing it

@evilsocket
Copy link
Owner

it is just dumb to rely on aircrack only as i always said.

@FrixosTh
Copy link
Contributor

FrixosTh commented Nov 7, 2019

I really liked the concept of the plugin and I would love to see it stay.. as I mentioned on my previous comment, all issues up to now should be resolved in the next release since this bug references an older version.. but it's your project and the final decision...

@evilsocket
Copy link
Owner

I'm just moving some of the plugins in a separate repositories of user contributed plugins, so we don't have to fix issues created by broken plugins in the core.

Also, let me reiterate: relying on aircrack only to filter handshakes will delete a bunch of good pcap files that you might crack with hashcat.

The assumption that aircrack can properly filter that stuff is wrong, it misses a lot of stuff.

dadav pushed a commit to dadav/pwnagotchi that referenced this issue Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants