Allows lefthook to work when node_modules is not in root folder for npx #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npx will automatically install the module if not present. yarn does not do this and complains when the package.json is not found.
|
the reason for this is that my project has a main folder and a /src folder. the package.json and node_modules is found in the src folder and therefore npx lefthook is not found but it is also not automatically installed because it is missing the @Arkweid |
|
Thank you! |
|
can this be released? |
PikachuEXE
reviewed
Sep 28, 2021
| @@ -21,7 +21,7 @@ call_lefthook() | |||
| elif bundle exec lefthook -h >/dev/null 2>&1 | |||
| then | |||
| bundle exec lefthook $1 | |||
| elif npx lefthook -h >/dev/null 2>&1 | |||
| elif npx @arkweid/lefthook -h >/dev/null 2>&1 | |||
| then | |||
| npx lefthook $1 | |||
There was a problem hiding this comment.
Should this line be updated too?
There was a problem hiding this comment.
It may be updated and may be not updated. npx seems to search for binaries both in node_modules and in system PATH, so if if statement above if passes then there will be lefthook binary in node_modules.
There was a problem hiding this comment.
no, that wont work. maybe both should be checked. this is for the case when the module is not in the root of the git project. so doing npx lefthook wont run it.
There was a problem hiding this comment.
Oh yeah, my bad. The line below also needs to be npx @arkweid/lefthook
PikachuEXE
added a commit
to PikachuEXE/lefthook
that referenced
this pull request
Sep 29, 2021
Doc fixed in evilmartians#218 Template partially fixed in evilmartians#224
Envek
pushed a commit
that referenced
this pull request
Oct 2, 2021
Envek
pushed a commit
that referenced
this pull request
Oct 2, 2021
…px (#224) npx will automatically install the module if not present. yarn does not do this and complains when the package.json is not found.
Envek
pushed a commit
that referenced
this pull request
Oct 2, 2021
|
Released in 0.7.7 |
Envek
added a commit
that referenced
this pull request
Jun 6, 2022
* origin/0-7-stable: 0.7.7: Fix arguments passing and various NPM-related fixes Fix incorrect npx command in git hook script template (#236) Update project URLs in NPM package.json (#235) Pass all arguments to downstream hooks (#231) Allows lefthook to work when node_modules is not in root folder for npx (#224) Do not initialize git config on `help` and `version` commands (#209) node: fix postinstall: process.cwd is a function and should be called
mrexox
added a commit
that referenced
this pull request
Jun 9, 2022
* master: Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip] Include version into RPM/DEB packages on release [ci skip] 0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package Split NPM package to two: bundled and installer (#273) Include archived binaries in the releases (#189) docs: s/agrs/args (#265) [ci skip] chore(lint): Fix golangci-lint complains docs(usage): Add commitlint example in full_guide (#201) Fix unreachable conditional in hook template (#242) fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260) Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263) Fix typo in docs/full_guide.md (#256) 0.7.7: Fix arguments passing and various NPM-related fixes Fix incorrect npx command in git hook script template (#236) Update project URLs in NPM package.json (#235) Pass all arguments to downstream hooks (#231) Allows lefthook to work when node_modules is not in root folder for npx (#224) Do not initialize git config on `help` and `version` commands (#209) node: fix postinstall: process.cwd is a function and should be called Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx will automatically install the module if not present. yarn does not do this and complains when the package.json is not found.