Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSpec #175

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix RSpec #175

merged 2 commits into from
May 4, 2021

Conversation

skryukov
Copy link
Member

@skryukov skryukov commented May 2, 2021 •
edited
Loading

This PR fixes the broken RSpec suite. We'd port it to the native go tests later. Or can we consider removing it instead of fixing it?

@skryukov skryukov requested review from Envek and DmitryTsepelev May 2, 2021 20:45
DmitryTsepelev
DmitryTsepelev approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@DmitryTsepelev DmitryTsepelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep both suites for now and port—at least we have more checks to make things harder to break

@skryukov skryukov force-pushed the fix/rspec-tests branch from 6c17279 to e9440ec Compare May 4, 2021 15:20
@Envek Envek merged commit 942e109 into master May 4, 2021
@Envek Envek deleted the fix/rspec-tests branch May 4, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Envek Envek Envek approved these changes

@DmitryTsepelev DmitryTsepelev DmitryTsepelev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skryukov @Envek @DmitryTsepelev