New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility for using multiple file types (#101) #103

Merged

Arkweid merged 1 commit into evilmartians:master from rbUUbr:feature/add-support-of-multiple-file-extensions

Feb 2, 2020

Contributor

rbUUbr commented Jan 18, 2020 •

edited

Loading

Closes #101
Added possibility to use files for a config with yaml extension.
Questions to discuss:

I haven't added tests, because locally they are failed even on the master, Do I need to perform something special?
In cmd/install.go:189 you can see primaryMatch, this code will just take first match fr config file. Do we need anything special for it? (IMHO, no)


          Add possibility for using multiple file types

46092d0

rbUUbr requested a review from Arkweid

January 18, 2020 23:04

Collaborator

Arkweid commented Jan 20, 2020

Awesome! If it not urgent I will check it soon.

Arkweid merged commit 4e023ef into evilmartians:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet