client: add some TODOs

evenh · May 1, 2019 · 8aa026c · 8aa026c
1 parent e465c32
commit 8aa026c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/client/client.go b/client/client.go
@@ -30,7 +30,7 @@ func StartClient(config *config.ClientConfig, userAgent string) {
 	log.Infof("Configuring connection to %s for gRPC operations", config.GetDialAddr())
 
 	// Configure connection
-	// TODO: Not run insecure
+	// TODO: Use TLS for encrypting connection (with configurable certs and a sane default)
 	conn, err := grpc.Dial(
 		config.GetDialAddr(),
 		grpc.WithBackoffConfig(grpc.DefaultBackoffConfig),

diff --git a/client/tasks.go b/client/tasks.go
@@ -18,8 +18,10 @@ func pingServer(client api.CertificateIssuerClient) func() {
 	}
 }
 
+// Listen for events from the server, indicating that a certificate has been renewed with ACME
 func watchForEvents(domains []string, client api.CertificateIssuerClient) func() {
 	return func() {
+		// TODO: Automatic resubscribe when a stream dies for some reason (e.g. server goes down)
 		renewalStream, err := client.OnCertificateRenewal(context.Background(), &api.CertificateRenewalNotificationRequest{
 			DnsNames: domains,
 		})