Refactor green share calculation #4760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofyyy
reviewed
Oct 23, 2022
There was a problem hiding this comment.
Hi @naltatis,
Ich habe alles einmal im Detail durchgelesen und kann erstmal nichts negatives finden.
Auch wenn ich noch keinen sehr großen Einblick in die EVCC Architektur habe.
Ein Punkt den ich anmerken könnte:
- Refactoring wenn möglich entweder "Form" oder "Function".
In dem Fall wären zwei Commits mega. Ein Commit der alles Verschiebt, aber kein Verhalten ändert (Tests bleiben gleich). Und ein zweiter Commit der auf den Greenshare umstellt. Das macht das Review einfacher und reduziert Fehler.
|
@andig rein damit? |
andig
reviewed
Nov 1, 2022
| // greenShare returns the percentage of self produced energy currently used at the site. 0 = full-grid; 1 = full pv/battery. | ||
| func (site *Site) greenShare() float64 { | ||
| batteryDischarge := math.Max(0, site.batteryPower) | ||
| batteryCharge := math.Min(0, site.batteryPower) * -1 |
There was a problem hiding this comment.
Magst die komplizierte Minusrechnung noch anpassen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
savings.gotosite.goto make result reusable in savings, telemetry and sessions (later)greenSharevalue0means currently no self-produced energy used1means all usage is covered by pv or battery