Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): Fix minimum version error on old versions of npm #93

Closed
wants to merge 2 commits into from

Conversation

getspooky
Copy link

This can happen if you have a dependency which lists an old version of npm in its own dependencies.

@evanw
Copy link
Owner

evanw commented May 9, 2020

Thank you for trying to fix this issue. However, I would like to understand what the issue is first and make sure I can reproduce it myself. I tried these commands but I couldn't reproduce the issue:

npm install npm@4
npm install esbuild
npx esbuild

Can you provide steps that would help me reproduce the issue myself?

If the issue that the older version of npm from the local node_modules folder somehow overrides the newer one that's installed globally, I think a better fix would be to use the npm_execpath environment variable to derive the location of npm so that it's not subject to path resolution. That way the install script would still work even if you end up in this scenario.

@evanw evanw force-pushed the master branch 6 times, most recently from 7d92d8a to a6dfabd Compare June 11, 2020 08:24
@evanw evanw force-pushed the master branch 2 times, most recently from 5b6b355 to 6e3ef52 Compare July 12, 2020 07:45
@evanw evanw closed this in 8da1b58 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants