Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entryPoint information in metafile #811

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Conversation

remorses
Copy link
Contributor

@remorses remorses commented Feb 15, 2021

Close #711

Adds a entryPoint field in the metafile

{
  "outputs": {
    "react/index.js": {
      "entryPoint": "src/entry.js",
      "exports": ["default"],
      "imports": [
        ...
      ],
    
    }
}

@remorses remorses changed the title Facade module Facade module id information in metafile Feb 15, 2021
@evanw
Copy link
Owner

evanw commented Feb 18, 2021

Not sure we want to use this name, maybe inputEntrypoint is better?

Yeah "facade" doesn't tell me anything about what this property means. Maybe just entryPoint to mirror the entryPoints API option?

Note to self: This PR doesn't mark CSS files generated by importing CSS from a JavaScript entry point with this property. However, I think that is actually a good idea because that keeps it a 1:1 mapping. And in the future, I may need to generate more than one CSS file in this case so annotating the CSS files with this property is potentially confusing. I think I should instead add a new property to link the JavaScript entry point to the necessary CSS files instead.

@remorses remorses changed the title Facade module id information in metafile entryPoint information in metafile Feb 19, 2021
@remorses remorses marked this pull request as ready for review February 19, 2021 11:39
@evanw evanw merged commit b6f8b82 into evanw:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: facadeModuleId in metafile outputs
2 participants