Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add footer and banner for css file #775

Closed
wants to merge 1 commit into from
Closed

Feat: add footer and banner for css file #775

wants to merge 1 commit into from

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 9, 2021

Close #712

add css-footer and css-banner for CSS file

@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 9, 2021

@evanw Hi, could you take a look for this, something similar with #531

@evanw
Copy link
Owner

evanw commented Feb 13, 2021

I am planning for this to be a breaking API change instead of fixing it in a non-breaking change like this. I want to keep the API surface small and use a map like outExtension instead of having a separate flag per content type, especially since there may be even more content types than JS and CSS in the future.

@susiwen8 susiwen8 closed this Feb 13, 2021
@susiwen8 susiwen8 deleted the css-footer-banner branch February 19, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

banner and footer flags are not honored in minified CSS
2 participants
@susiwen8 @evanw