Skip to content

Commit

Permalink
fix an issue with the publishing script
Browse files Browse the repository at this point in the history
  • Loading branch information
evanw committed Dec 14, 2021
1 parent 1c82acf commit 28f14ba
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

* Fix an issue with the publishing script

This release fixes a missing dependency issue in the publishing script where it was previously possible for the published binary executable to have an incorrect version number.

## 0.14.4

* Adjust esbuild's handling of `default` exports and the `__esModule` marker ([#532](https://github.com/evanw/esbuild/issues/532), [#1591](https://github.com/evanw/esbuild/issues/1591), [#1719](https://github.com/evanw/esbuild/issues/1719))
Expand Down
13 changes: 5 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ wasm-napi-exit0-windows:
main.bat
rm -f main.*

platform-all: cmd/esbuild/version.go
platform-all:
@$(MAKE) --no-print-directory -j4 \
platform-windows \
platform-windows-32 \
Expand All @@ -237,19 +237,19 @@ platform-all: cmd/esbuild/version.go
platform-neutral \
platform-deno

platform-windows:
platform-windows: cmd/esbuild/version.go
node scripts/esbuild.js npm/esbuild-windows-64/package.json --version
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build $(GO_FLAGS) -o npm/esbuild-windows-64/esbuild.exe ./cmd/esbuild

platform-windows-32:
platform-windows-32: cmd/esbuild/version.go
node scripts/esbuild.js npm/esbuild-windows-32/package.json --version
CGO_ENABLED=0 GOOS=windows GOARCH=386 go build $(GO_FLAGS) -o npm/esbuild-windows-32/esbuild.exe ./cmd/esbuild

platform-windows-arm64:
platform-windows-arm64: cmd/esbuild/version.go
node scripts/esbuild.js npm/esbuild-windows-arm64/package.json --version
CGO_ENABLED=0 GOOS=windows GOARCH=arm64 go build $(GO_FLAGS) -o npm/esbuild-windows-arm64/esbuild.exe ./cmd/esbuild

platform-unixlike:
platform-unixlike: cmd/esbuild/version.go
@test -n "$(GOOS)" || (echo "The environment variable GOOS must be provided" && false)
@test -n "$(GOARCH)" || (echo "The environment variable GOARCH must be provided" && false)
@test -n "$(NPMDIR)" || (echo "The environment variable NPMDIR must be provided" && false)
Expand Down Expand Up @@ -309,9 +309,6 @@ platform-neutral: esbuild
platform-deno: esbuild
node scripts/esbuild.js ./esbuild --deno

test-otp:
test -n "$(OTP)" && echo publish --otp="$(OTP)"

publish-all:
@npm --version > /dev/null || (echo "The 'npm' command must be in your path to publish" && false)
@echo "Checking for uncommitted/untracked changes..." && test -z "`git status --porcelain | grep -vE 'M (CHANGELOG\.md|version\.txt)'`" || \
Expand Down
2 changes: 1 addition & 1 deletion cmd/esbuild/version.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package main

const esbuildVersion = "0.14.3"
const esbuildVersion = "0.14.4"

0 comments on commit 28f14ba

Please sign in to comment.