Skip to content

Commit

Permalink
Fix review.
Browse files Browse the repository at this point in the history
  • Loading branch information
dengliming authored and evantorrie committed Sep 10, 2020
1 parent 718ac5d commit f9a21be
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The environment variable used for resource detection has been changed from `OTEL_RESOURCE_LABELS` to `OTEL_RESOURCE_ATTRIBUTES` (#1042)
- Replace `WithSyncer` with `WithBatcher` in examples. (#1044)
- Replace the `google.golang.org/grpc/codes` dependency in the API with an equivalent `go.opentelemetry.io/otel/codes` package. (#1046)
- Unify Callback Function Naming.
Rename `*Callback` with `*Func`. (#1061)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion api/metric/async.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ type Int64ObserverResult struct {
function func([]kv.KeyValue, ...Observation)
}

// Float64ObserverResult is passed to an observer callback to captureGetHookFunc
// Float64ObserverResult is passed to an observer callback to capture
// observations for one asynchronous floating point metric instrument.
type Float64ObserverResult struct {
instrument AsyncImpl
Expand Down

0 comments on commit f9a21be

Please sign in to comment.