fixup: no read locks on Mac

eugeneo · Dec 10, 2024 · d19f0fa · d19f0fa
1 parent 6512c35
commit d19f0fa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/core/lib/event_engine/posix_engine/posix_system_api.cc b/src/core/lib/event_engine/posix_engine/posix_system_api.cc
@@ -63,21 +63,15 @@ namespace {
 class LocksState {
  public:
   void Lock(const SystemApi* system_api, int fd) {
-#ifdef GPR_ABSEIL_SYNC
     if (++counters_[system_api] == 1) {
       system_api->ReaderLock();
     }
-    LOG_EVERY_N(INFO, 10) << "Locks: " << counters_[system_api];
-#endif
   }
 
   void Unlock(const SystemApi* system_api, int fd) {
-#ifdef GPR_ABSEIL_SYNC
-    CHECK_GE(counters_[system_api], 0);
     if (--counters_[system_api] == 0) {
       system_api->ReaderUnlock();
     }
-#endif
   }
 
  private:

diff --git a/src/core/lib/event_engine/posix_engine/posix_system_api.h b/src/core/lib/event_engine/posix_engine/posix_system_api.h
@@ -131,10 +131,18 @@ class SystemApi {
 
   absl::Status AdvanceGeneration();
 
-  void ReaderLock() const ABSL_NO_THREAD_SAFETY_ANALYSIS { mu_.ReaderLock(); }
+  void ReaderLock() const ABSL_NO_THREAD_SAFETY_ANALYSIS {
+    // Fork is not supported on Mac. This guard should be replaced accordingly.
+#ifdef GPR_ABSEIL_SYNC
+    mu_.ReaderLock();
+#endif
+  }
 
   void ReaderUnlock() const ABSL_NO_THREAD_SAFETY_ANALYSIS {
+    // Fork is not supported on Mac. This guard should be replaced accordingly.
+#ifdef GPR_ABSEIL_SYNC
     mu_.ReaderUnlock();
+#endif
   }
 
   absl::StatusOr<FileDescriptor> Accept(FileDescriptor sockfd,