Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Header-Case #9

Closed
wants to merge 1 commit into from
Closed

Add Header-Case #9

wants to merge 1 commit into from

Conversation

abemedia
Copy link

@abemedia abemedia commented Jan 10, 2023

What does this fix or improve?

Adds the default casing used in HTTP headers i.e. capitalised snake case. I realise this can easily be achieved with ToCase, however this is a common casing so I felt it deserved first-class support.

Also fixed Makefile to use the newer go install command.

Is this a breaking change API change or change in behavior?

No

Checklist:

  • I have updated the documentation accordingly, if needed.
  • I have added appropriate tests, if needed.

@liyanchang
Copy link
Collaborator

Hi! Glad you're finding this library helpful!

I'm inclined to just leave it as is for the moment - as you mentioned, it's easy enough to just use ToCase. Obviously, I'm open to adding it if there's more interest from a wide range of users.

I appreciate the thoughtfulness you had in making sure you added tests, docs, etc. I'm definitely open to PR that's limited to just docs and makefile changes.

Thanks!

@liyanchang liyanchang closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants