-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve processing of composite tags #297
Conversation
Regression test results on commit abf3c98
This comment will be updated when new commits are added to the PR. |
@@ -615,7 +615,7 @@ def process_user_constraint_tables( | |||
""" | |||
legal_values = { | |||
"attribute": {attr for attr in config.all_attributes if attr.startswith("uc")}, | |||
"region": model.internal_regions, | |||
"region": model.internal_regions.union({"allregions".upper()}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha why not just "ALLREGIONS"? :)
(No need to change it though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to forget that those elements should be uppercase 😂
No description provided.