Skip to content

Commit

Permalink
Fix navbarBurger tag from <a> to <div> avoiding page reload.
Browse files Browse the repository at this point in the history
When following the example provided in the documentation, clicking on the
burger triggers a page reload. As suggested in an issue on the official
Bulma GitHub repository (jgthms/bulma#1515),
changing the <a> to a <div> fixes the problem.
  • Loading branch information
etiennebatise committed Nov 24, 2019
1 parent 4b46323 commit 2060a91
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Bulma/Components.elm
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ When its first argument is `True`, it transforms into a `navbarCross`.
-}
navbarBurger : IsActive -> List (Attribute msg) -> List (Html msg) -> NavbarBurger msg
navbarBurger isActive = node "a" [ B.navbarBurger, if isActive then B.isActive else B.none ]
navbarBurger isActive = node "div" [ B.navbarBurger, if isActive then B.isActive else B.none ]

{-| A simple "X" character; the active version of `navbarBurger`.
-}
Expand Down

0 comments on commit 2060a91

Please sign in to comment.