fix: fail if updating or removing by non-existing id

etienne-bechara · May 3, 2021 · ce2acc3 · ce2acc3
1 parent da2eefd
commit ce2acc3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/source/orm/orm.service.ts b/source/orm/orm.service.ts
@@ -288,7 +288,7 @@ export abstract class OrmService<Entity> {
    * @param options
    */
   public async updateById(id: string, data: EntityData<Entity>, options: OrmUpdateOptions<Entity> = { }): Promise<Entity> {
-    const entity = await this.readById(id);
+    const entity = await this.readByIdOrFail(id);
     const updatedEntity = await this.update({ entity, data }, options);
     return updatedEntity[0];
   }
@@ -462,7 +462,7 @@ export abstract class OrmService<Entity> {
    * @param id
    */
   public async removeById(id: string): Promise<Entity> {
-    const entity = await this.readById(id);
+    const entity = await this.readByIdOrFail(id);
     await this.remove(entity);
     return entity;
   }