fix: make controller options optional

etienne-bechara · Apr 21, 2021 · c425955 · c425955
1 parent 4cc80bb
commit c425955
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/source/orm/orm.controller.ts b/source/orm/orm.controller.ts
@@ -17,7 +17,7 @@ export abstract class OrmController<Entity> {
 
   public constructor(
     public readonly entityService: OrmService<Entity>,
-    protected readonly controllerOptions: OrmControllerOptions,
+    protected readonly controllerOptions: OrmControllerOptions = { },
   ) { }
 
   /**
@@ -26,7 +26,7 @@ export abstract class OrmController<Entity> {
    */
   private async validateRequest(params: OrmRequestValidation): Promise<OrmValidationData> {
     const options = this.controllerOptions;
-    let queryData, queryOptions;
+    options.methods ??= [ 'GET', 'GET:id', 'POST', 'PUT', 'PUT:id', 'PATCH:id', 'DELETE:id' ];
     options.dto ??= { };
 
     if (!options.methods.includes(params.method)) {
@@ -41,6 +41,8 @@ export abstract class OrmController<Entity> {
       await this.plainToDto(params.update, options.dto.update);
     }
 
+    let queryData, queryOptions;
+
     if (params.read && options.dto.read) {
       const paginationProperties = [ 'sort', 'order', 'limit', 'offset' ];
       const parsedQuery = this.parseFilterOperators(params.read);

diff --git a/source/orm/orm.interface/orm.controller.options.ts b/source/orm/orm.interface/orm.controller.options.ts
@@ -1,7 +1,7 @@
 import { OrmControllerMethod } from '../orm.enum';
 
 export interface OrmControllerOptions {
-  methods: OrmControllerMethod[];
+  methods?: OrmControllerMethod[];
   dto?: OrmControllerDto;
 }