Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LJ-309: allow privacy notices to be assigned to TCF components #5730

Merged
merged 6 commits into from
Feb 6, 2025
Merged

LJ-309: allow privacy notices to be assigned to TCF components #5730

merged 6 commits into from
Feb 6, 2025

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Feb 4, 2025 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/LJ-309

Description Of Changes

Exposes privacy notice picker to add privacy notices to TCF components

Code Changes

  • Expose privacy notice picker for TCF components
  • Adjust Add privacy notices to banner toggle to only display for banner_and_modal components

Steps to Confirm

Please test alongside https://github.com/ethyca/fidesplus/pull/1836

  1. Run nox -s "build(slim)" "dev(slim)" -- dev on https://github.com/ethyca/fidesplus/pull/1836 branch
  2. Run this PR within /clients/admin-ui with turbo run dev
  3. Update a TCF experience with notices, confirm it's saved correctly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 10:41am

@cypress Cypress
Copy link

cypress bot commented Feb 4, 2025 •
edited
Loading

fides    Run #12194

Run Properties:  status check passed Passed #12194  •  git commit ffbfd6b5ff ℹ️: Merge e926c2bf56cfcf6fb8052a5d2527b900b17390ac into c487c32153aeebe1fe17fd829142...
Project fides
Branch Review refs/pull/5730/merge
Run status status check passed Passed #12194
Run duration 00m 47s
Commit git commit ffbfd6b5ff ℹ️: Merge e926c2bf56cfcf6fb8052a5d2527b900b17390ac into c487c32153aeebe1fe17fd829142...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

gilluminate
gilluminate approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested locally and working as expected.

@eastandwestwind eastandwestwind merged commit 2770ed6 into main Feb 6, 2025
20 checks passed
@eastandwestwind eastandwestwind deleted the LJ-309 branch February 6, 2025 11:30
@cypress Cypress
Copy link

cypress bot commented Feb 6, 2025

fides    Run #12195

Run Properties:  status check passed Passed #12195  •  git commit 2770ed6a14: LJ-309: allow privacy notices to be assigned to TCF components (#5730)
Project fides
Branch Review main
Run status status check passed Passed #12195
Run duration 00m 48s
Commit git commit 2770ed6a14: LJ-309: allow privacy notices to be assigned to TCF components (#5730)
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastandwestwind @gilluminate