Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .only from test suite #5517

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Remove .only from test suite #5517

merged 1 commit into from
Nov 19, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 19, 2024

Closes unticketed

Description Of Changes

Removes a .only that was accidentally left in the D&D Cypress test suite.

Steps to Confirm

  1. CI passes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:17pm

Copy link

cypress bot commented Nov 19, 2024

fides    Run #11093

Run Properties:  status check passed Passed #11093  •  git commit 78a3ae60a2 ℹ️: Merge a8f46088b41a5ac7ec8febc131c1f1f3928e9a2b into ee3924d87875c34d72324f6bf156...
Project fides
Branch Review refs/pull/5517/merge
Run status status check passed Passed #11093
Run duration 00m 39s
Commit git commit 78a3ae60a2 ℹ️: Merge a8f46088b41a5ac7ec8febc131c1f1f3928e9a2b into ee3924d87875c34d72324f6bf156...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@jpople jpople merged commit 6ea0944 into main Nov 19, 2024
13 checks passed
@jpople jpople deleted the jpople/remove-.only branch November 19, 2024 21:54
Copy link

cypress bot commented Nov 19, 2024

fides    Run #11094

Run Properties:  status check passed Passed #11094  •  git commit 6ea0944dba: Remove .only from test suite (#5517)
Project fides
Branch Review main
Run status status check passed Passed #11094
Run duration 00m 48s
Commit git commit 6ea0944dba: Remove .only from test suite (#5517)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants