Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new "All" GPP approach #5480

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Support new "All" GPP approach #5480

merged 2 commits into from
Nov 8, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 8, 2024 •
edited
Loading

Closes HJ-167, HJ-84

Description Of Changes

  • Under “Settings > Consent” IN the US GPP section, I can choose a third option: “Enable US National and State-by-State notices”
  • Fides allows users to configure both the national and state notices simultaneously.
  • The CMP includes the national section as a parsed and applicable section when a user visits from a location with an experience configured to display the national section.
  • The CMP still includes the appropriate state section as a parsed and applicable section when a user visits from a state with an experience configured to display that state section.

Code Changes

  • Adds new configuration option to set the approach to GPPUSApproach.ALL on consent settings page
  • Fixes button size on consent settings page (HJ-84)
  • Updates fides-js/src/fides-ext-gpp.ts and fides-js/src/lib/gpp/us-notices.ts to support the new GPPUSApproach.ALL option appropriately
  • Adds unit tests

Steps to Confirm

  1. Visit the Consent Settings page in Admin UI (/settings/consent)
  2. Ensure that the GPP status is "Enabled"
  3. In the GPP U.S. section, select the new, 3rd option "Enable US National and State-by-State notices"
  4. Notice the [Save] button at the bottom of the screen is no longer taking up the entire width of the page. Click it to save the option selected.
  5. Visit the Notices page (/consent/privacy-notices)
  6. Notice that both US State and US National notices are available
  7. Ensure that a state-by-state targeted advertising notice and a national targeted advertising notice are enabled
  8. Visit the Experience page (/consent/privacy-experience)
  9. Assign the state-by-state targeted advertising notice to a privacy experience with the locations of CA, UT, CO, VA, CT
  10. Assign the national targeted advertising notices to a privacy experience with the locations of MT, TX, IA, OR, WA
  11. Visit the cookie house from Colorado and inspect the GPP API in the browser console to make sure that the parsed section is CO (uscov1), and the CO section number is listed in the applicableSections property __gpp('ping', (data) => {console.log(data)})
  12. Visit the cookie house from MT and inspect the GPP API in the browser console to make sure that the parsed section is USNAT (usnatv1), and the USNAT section number is listed in the applicableSections property
  13. Visit the Privacy Center demo page and load Fides.js with the gpp=true param from a location that is not configured in either experience and make sure the applicableSections value is [-1] (eg. /fides-js-demo.html?geolocation=us-id&gpp=true for Idaho).

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 7:15pm

@gilluminate gilluminate force-pushed the gill/HJ-167/gpp-allow-national-string branch from 0ce95a1 to 593b7c8 Compare November 8, 2024 19:15
@cypress Cypress
Copy link

cypress bot commented Nov 8, 2024 •
edited
Loading

fides    Run #10902

Run Properties:  status check passed Passed #10902  •  git commit 52d6a24d16 ℹ️: Merge 593b7c8ad194665d8098fd7b70695d57c3016327 into 306202ef00da7a5e73701663602a...
Project fides
Branch Review refs/pull/5480/merge
Run status status check passed Passed #10902
Run duration 00m 38s
Commit git commit 52d6a24d16 ℹ️: Merge 593b7c8ad194665d8098fd7b70695d57c3016327 into 306202ef00da7a5e73701663602a...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

jpople
jpople approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (at great cost), working as expected.

@gilluminate gilluminate merged commit 993aea1 into main Nov 8, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/HJ-167/gpp-allow-national-string branch November 8, 2024 21:42
@cypress Cypress
Copy link

cypress bot commented Nov 8, 2024

fides    Run #10903

Run Properties:  status check passed Passed #10903  •  git commit 993aea1a4c: Support new "All" GPP approach (#5480)
Project fides
Branch Review main
Run status status check passed Passed #10903
Run duration 00m 41s
Commit git commit 993aea1a4c: Support new "All" GPP approach (#5480)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Kelsey-Ethyca pushed a commit that referenced this pull request Nov 11, 2024
@gilluminate @Kelsey-Ethyca
Support new "All" GPP approach (#5480)
7ff28bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @jpople